Add conversation_id to valid thread metadata keys - #5774
Open
Seán (seanderoiste) wants to merge 1 commit into
Open
Add conversation_id to valid thread metadata keys#5774Seán (seanderoiste) wants to merge 1 commit into
Seán (seanderoiste) wants to merge 1 commit into
Conversation
The tracer ingest pipeline accepts three keys as aliases for thread grouping (session_id, conversation_id, thread_id), but the docs listed only two. Add conversation_id and note the check order. See smith-go/queue/ingest/prepare_run_payload.go:145 for the source of truth.
Contributor
|
Thanks for opening a docs PR, Seán (@seanderoiste)! When it's ready for review, please add the relevant reviewers:
|
Contributor
|
Mintlify preview branch generated: Site preview: https://langchain-5e9cc07a-preview-docsth-1788110737-21a516d.mintlify.site Important Preview links may take a few minutes to start working while the deployment finishes. Changed documentation pages (preview deep links): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The tracer's ingest pipeline accepts three metadata keys as aliases for thread grouping, but the docs listed only two. As a result, users following the docs might not know that
conversation_idis a valid alias, and users who already useconversation_id(a natural name for chat frameworks) might assume their threads are misconfigured when in fact they are grouping correctly.Source of truth
smith-go/queue/ingest/prepare_run_payload.go:145:```go
for _, k := range []string{"session_id", "conversation_id", "thread_id"} {
```
The ingest layer checks the three keys in this order and uses the first one present.
Change
src/langsmith/threads.mdx:conversation_idto the bulleted list of valid keys.conversation_idalongsidesession_idandthread_id.Other pages that mention this list
Several other pages still list only
session_idandthread_id. Left them out of this PR to keep the change focused, but flagging for follow-up:Some of these may be intentionally two-key (query/filter side vs ingest side) — worth someone with more context looking.
AI involvement
Drafted with Claude Code. Change and PR description reviewed by human.